Skip to content

RHDEVDOCS-6317: Post GA changes for GitOps 1.16 #91491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

RHDEVDOCS-6317: Post GA changes for GitOps 1.16 #91491

merged 1 commit into from
Apr 8, 2025

Conversation

Dhruv-Soni11
Copy link
Contributor

@Dhruv-Soni11 Dhruv-Soni11 commented Apr 2, 2025 •
edited by mburke5678
Loading

Version(s):

GitOps 1.16

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6317

Link to docs preview:

Incorrectly rendering attribute in the Enable the creation of aggregated cluster roles section

Deprecated and removed features in GitOps 1.16 Release Notes

Note under the About RedHat OpenShift GitOps section

QE review:

  • QE has approved this change.

Change management:
Need an ACK from Eng: [email protected] @svghadi
Need an ACK from PM: @harrietgrace
Need an ACK from Product Release Lead: @anand Francis
Need an ACK from QE: @varshab1210
Need an ACK from DPM: [email protected]
Need an ACK from CS: @Preeticp
Need an ACK from Peer reviewer: @michaelryanpeter
Need an ACK from Merge reviewer: @mburke5678

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 2, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 2, 2025 •
edited
Loading

🤖 Tue Apr 08 15:22:38 - Prow CI generated the docs preview:

https://91491--ocpdocs-pr.netlify.app/openshift-gitops/latest/declarative_clusterconfig/customizing-permissions-by-creating-aggregated-cluster-roles.html
https://91491--ocpdocs-pr.netlify.app/openshift-gitops/latest/release_notes/gitops-release-notes-1-16.html
https://91491--ocpdocs-pr.netlify.app/openshift-gitops/latest/understanding_openshift_gitops/about-redhat-openshift-gitops.html

anandrkskd
anandrkskd approved these changes Apr 2, 2025
View reviewed changes
svghadi
svghadi approved these changes Apr 2, 2025
View reviewed changes
Copy link

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2025
varshab1210
varshab1210 reviewed Apr 2, 2025
View reviewed changes
Copy link

@varshab1210 varshab1210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2025
@Dhruv-Soni11 Dhruv-Soni11 changed the title Fixing a few defects and adding a RN for GitOps 1.16 RHDEVDOCS-6317: Fixing a few defects and adding a RN for GitOps 1.16 Apr 2, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 2, 2025 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-6317 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.16

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6317

Link to docs preview:

Incorrectly rendering attribute in the Enable the creation of aggregated cluster roles section

Deprecated and removed features in GitOps 1.16 Release Notes

Note under the About RedHat OpenShift GitOps section

QE review:

  • QE has approved this change.

SME review: [email protected] @svghadi
QE review: @varshab1210
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 2, 2025 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-6317 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.16

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6317

Link to docs preview:

Incorrectly rendering attribute in the Enable the creation of aggregated cluster roles section

Deprecated and removed features in GitOps 1.16 Release Notes

Note under the About RedHat OpenShift GitOps section

QE review:

  • QE has approved this change.

SME review: [email protected] @svghadi
QE review: @varshab1210
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Dhruv-Soni11
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 2, 2025
@michaelryanpeter
Copy link
Contributor

/label peer-review-needed

michaelryanpeter
michaelryanpeter reviewed Apr 2, 2025
View reviewed changes
Copy link
Contributor

@michaelryanpeter michaelryanpeter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that updates to release notes outside of a major, minor, or patch release requires change management. Consult with your DPM or content strategist to see if this PR qualifies for an "announcement" change management email to stakeholders. Please refer to the OpenShift Docs Manual or reach out on Slack if you have questions about the CM process.

Otherwise, just a small style issue regarding API object formatting.

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 2, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 2, 2025

@michaelryanpeter: Those labels are not set on the issue: peer-review-in-progress

In response to this:

Please note that updates to release notes outside of a major, minor, or patch release require change management. Consult with your DPM or content strategist to see if this PR qualifies for an "announcement" change management email to stakeholders. Please refer to the OpenShift Docs Manual or reach out on Slack if you have questions about the CM process.

Otherwise, just a small style issue regarding API object formatting.

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@michaelryanpeter michaelryanpeter added this to the Continuous Release milestone Apr 2, 2025
@Dhruv-Soni11 Dhruv-Soni11 changed the title RHDEVDOCS-6317: Fixing a few defects and adding a RN for GitOps 1.16 RHDEVDOCS-6317: Post GA changes for GitOps 1.16 Apr 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 3, 2025 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-6317 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.16

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6317

Link to docs preview:

Incorrectly rendering attribute in the Enable the creation of aggregated cluster roles section

Deprecated and removed features in GitOps 1.16 Release Notes

Note under the About RedHat OpenShift GitOps section

QE review:

  • QE has approved this change.

Change management:
Need an ACK from Eng: [email protected] @svghadi
Need an ACK from PM: @harrietgrace
Need an ACK from Product experience: @RickJWagner
Need an ACK from QE: @varshab1210
Need an ACK from DPM: [email protected]
Need an ACK from CS: @Preeticp
Need an ACK from Peer reviewer: @michaelryanpeter
Need an ACK from Merge reviewer:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Dhruv-Soni11
Copy link
Contributor Author

Please note that updates to release notes outside of a major, minor, or patch release requires change management. Consult with your DPM or content strategist to see if this PR qualifies for an "announcement" change management email to stakeholders. Please refer to the OpenShift Docs Manual or reach out on Slack if you have questions about the CM process.

Otherwise, just a small style issue regarding API object formatting.

/label peer-review-done /remove-label peer-review-needed /remove-label peer-review-in-progress

Thanks for the suggestion @michaelryanpeter. I have sent a Change Management email to the required stakeholders as per the process. Once I get their acks, I will send it for the merge review round.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 3, 2025 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-6317 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.16

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6317

Link to docs preview:

Incorrectly rendering attribute in the Enable the creation of aggregated cluster roles section

Deprecated and removed features in GitOps 1.16 Release Notes

Note under the About RedHat OpenShift GitOps section

QE review:

  • QE has approved this change.

Change management:
Need an ACK from Eng: [email protected] @svghadi
Need an ACK from PM: @harrietgrace
Need an ACK from Product Release Lead: @anand Francis
Need an ACK from QE: @varshab1210
Need an ACK from DPM: [email protected]
Need an ACK from CS: @Preeticp
Need an ACK from Peer reviewer: @michaelryanpeter
Need an ACK from Merge reviewer:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Preeticp
Copy link
Contributor

Preeticp commented Apr 3, 2025

CS Ack. I think change management is required primarily cause we added this: https://github.com/openshift/openshift-docs/pull/91491/files#diff-a86d57b5759e9b51c7809d425db698aa2e9aec3115aaadb163c554e6f8121265R103.

@wtam2018
Copy link
Contributor

wtam2018 commented Apr 3, 2025

/lgtm

@kavverma
Copy link

kavverma commented Apr 4, 2025

LGTM - DPM

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2025
@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-6317 branch 2 times, most recently from ea5ddd0 to 09294bb Compare April 7, 2025 12:07
svghadi
svghadi approved these changes Apr 7, 2025
View reviewed changes
Copy link

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anandf
anandf approved these changes Apr 7, 2025
View reviewed changes
Copy link

@anandf anandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anandrkskd
anandrkskd reviewed Apr 8, 2025
View reviewed changes
Copy link
Member

@anandrkskd anandrkskd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change, otherwise LGTM

@anandrkskd
Copy link
Member

LGTM
Thanks @Dhruv-Soni11 for changes

@harrietgrace
Copy link

LGTM!

@Dhruv-Soni11
Fixing a few defects and adding a RN for GitOps 1.16
4966f3f 
Implementing QE review comment

Incorporating peer review comments
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 8, 2025

@Dhruv-Soni11: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Dhruv-Soni11
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 8, 2025
@mburke5678 mburke5678 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 8, 2025
@mburke5678
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2025 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-6317 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.16

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6317

Link to docs preview:

Incorrectly rendering attribute in the Enable the creation of aggregated cluster roles section

Deprecated and removed features in GitOps 1.16 Release Notes

Note under the About RedHat OpenShift GitOps section

QE review:

  • QE has approved this change.

Change management:
Need an ACK from Eng: [email protected] @svghadi
Need an ACK from PM: @harrietgrace
Need an ACK from Product Release Lead: @anand Francis
Need an ACK from QE: @varshab1210
Need an ACK from DPM: [email protected]
Need an ACK from CS: @Preeticp
Need an ACK from Peer reviewer: @michaelryanpeter
Need an ACK from Merge reviewer: @mburke5678

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mburke5678 mburke5678 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 8, 2025
@mburke5678 mburke5678 merged commit 365743f into openshift:gitops-docs-main Apr 8, 2025
2 checks passed
@mburke5678
Copy link
Contributor

/cherrypick gitops-docs-1.16

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #91895

In response to this:

/cherrypick gitops-docs-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandrkskd anandrkskd anandrkskd approved these changes

@varshab1210 varshab1210 varshab1210 left review comments

@michaelryanpeter michaelryanpeter michaelryanpeter left review comments

@dfajmon dfajmon dfajmon left review comments

@anandf anandf anandf approved these changes

@jgwest jgwest jgwest approved these changes

@ranakan19 ranakan19 ranakan19 approved these changes

@svghadi svghadi svghadi approved these changes

Assignees

@mburke5678 mburke5678

@wtam2018 wtam2018

@svghadi svghadi

Labels
gitops jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.